Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing: mocked and memory #14

Merged
merged 12 commits into from
Dec 21, 2018
Merged

Testing: mocked and memory #14

merged 12 commits into from
Dec 21, 2018

Conversation

pimotte
Copy link
Contributor

@pimotte pimotte commented Dec 19, 2018 •
edited
Loading

This PR continues #13.

I'm splitting the tests in two categories:

  • Unit tests, which mock the connector and verify that correct calls have been
  • Integration tests, which use the memory connector to test scenarios

No state is carried over between tests.

@pimotte pimotte changed the title WIP: Testing: mocked and memory Testing: mocked and memory Dec 20, 2018
@pimotte
Copy link
Contributor Author

pimotte commented Dec 20, 2018 •
edited
Loading

@bkaptijn Ready for review:)

Also, I personally tend to merge without squashing, as this can cause confusion for anyone branching off the existing commits, because you're rewriting history. (Which for #13 was me :'))

This was referenced Dec 20, 2018
Open
Merged
@bkaptijn
Copy link
Contributor

Ok got you, no squashes :-)

@bkaptijn bkaptijn merged commit 10fc079 into discipl:master Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pimotte @bkaptijn